Replace RawPtr with RefPtr on StylePendingImage

third_party/WebKit/Source/core/css/CSSImageValue.cpp

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 10 matching lines @@
 #include "config.h"
 #include "core/css/CSSImageValue.h"
 
 #include "core/css/CSSMarkup.h"
 #include "core/dom/Document.h"
 #include "core/fetch/FetchInitiatorTypeNames.h"
 #include "core/fetch/FetchRequest.h"
 #include "core/fetch/ImageResource.h"
 #include "core/loader/MixedContentChecker.h"
 #include "core/style/StyleFetchedImage.h"
-#include "core/style/StylePendingImage.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityPolicy.h"
 
 namespace blink {
 
 CSSImageValue::CSSImageValue(const AtomicString& rawValue, const KURL& url, StyleImage* image)
     : CSSValue(ImageClass)
     , m_relativeURL(rawValue)
     , m_absoluteURL(url.string())
-    , m_image(image)
-    , m_accessedImage(image)
+    , m_isCachePending(!image)
+    , m_cachedImage(image)
 {
 }
 
 CSSImageValue::~CSSImageValue()
 {
 }
 
-StyleImage* CSSImageValue::cachedOrPendingImage()
-{
-    if (!m_image)
-        m_image = StylePendingImage::create(this);
-
-    return m_image.get();
-}
-
-StyleFetchedImage* CSSImageValue::cachedImage(Document* document, const ResourceLoaderOptions& options)
+StyleFetchedImage* CSSImageValue::cacheImage(Document* document, const ResourceLoaderOptions& options)
 {
     ASSERT(document);
 
-    if (!m_accessedImage) {
-        m_accessedImage = true;
+    if (m_isCachePending) {
+        m_isCachePending = false;
 
         FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty() ? FetchInitiatorTypeNames::css : m_initiatorName, options);
         request.mutableResourceRequest().setHTTPReferrer(SecurityPolicy::generateReferrer(m_referrer.referrerPolicy, request.url(), m_referrer.referrer));
 
         if (options.corsEnabled == IsCORSEnabled)
             request.setCrossOriginAccessControl(document->securityOrigin(), options.allowCredentials, options.credentialsRequested);
 
         if (ResourcePtr<ImageResource> cachedImage = ImageResource::fetch(request, document->fetcher()))
-            m_image = StyleFetchedImage::create(cachedImage.get(), document);
+            m_cachedImage = StyleFetchedImage::create(cachedImage.get(), document);
     }
 
-    return (m_image && m_image->isImageResource()) ? toStyleFetchedImage(m_image) : nullptr;
+    return (m_cachedImage && m_cachedImage->isImageResource()) ? toStyleFetchedImage(m_cachedImage) : nullptr;
 }
 
 void CSSImageValue::restoreCachedResourceIfNeeded(Document& document)
 {
-    if (!m_accessedImage || !m_image->isImageResource() || !document.fetcher())
+    if (m_isCachePending || !m_cachedImage->isImageResource() || !document.fetcher())
         return;
     if (document.fetcher()->cachedResource(KURL(ParsedURLString, m_absoluteURL)))
         return;
 
-    ImageResource* resource = m_image->cachedImage();
+    ImageResource* resource = m_cachedImage->cachedImage();
     if (!resource)
         return;
 
     FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty() ? FetchInitiatorTypeNames::css : m_initiatorName, resource->options());
     MixedContentChecker::shouldBlockFetch(document.frame(), resource->lastResourceRequest(),
         resource->lastResourceRequest().url(), MixedContentChecker::SendReport);
     document.fetcher()->requestLoadStarted(resource, request, ResourceFetcher::ResourceLoadingFromCache);
 }
 
 bool CSSImageValue::hasFailedOrCanceledSubresources() const
 {
-    if (!m_image || !m_image->isImageResource())
+    if (!m_cachedImage || !m_cachedImage->isImageResource())
         return false;
-    if (Resource* cachedResource = toStyleFetchedImage(m_image)->cachedImage())
+    if (Resource* cachedResource = toStyleFetchedImage(m_cachedImage)->cachedImage())
         return cachedResource->loadFailedOrCanceled();
     return true;
 }
 
 bool CSSImageValue::equals(const CSSImageValue& other) const
 {
     return m_absoluteURL == other.m_absoluteURL;
 }
 
 String CSSImageValue::customCSSText() const
 {
     // TODO(nainar): Serialise with quotation marks to match spec: https://drafts.csswg.org/cssom/#serialize-a-url
     return "url(" + quoteCSSURLIfNeeded(serializeStringWithoutQuotations(m_relativeURL)) + ")";
 }
 
 bool CSSImageValue::knownToBeOpaque(const LayoutObject* layoutObject) const
 {
-    return m_image ? m_image->knownToBeOpaque(layoutObject) : false;
+    return m_cachedImage ? m_cachedImage->knownToBeOpaque(layoutObject) : false;
 }
 
 DEFINE_TRACE_AFTER_DISPATCH(CSSImageValue)
 {
-    visitor->trace(m_image);
+    visitor->trace(m_cachedImage);
     CSSValue::traceAfterDispatch(visitor);
 }
 
 void CSSImageValue::reResolveURL(const Document& document)
 {
     KURL url = document.completeURL(m_relativeURL);
     AtomicString urlString(url.string());
     if (urlString == m_absoluteURL)
         return;
     m_absoluteURL = urlString;
-    m_accessedImage = false;
-    m_image.clear();
+    m_isCachePending = true;
+    m_cachedImage.clear();
 }
 
 } // namespace blink