Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 13686019: Add icons for peripheral device low battery notification (Closed)

Created:
7 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
7 years, 8 months ago
Reviewers:
oshima, Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add icons for peripheral device low battery notification Go to the bug tracker to see how it looks like. BUG=221420 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A chrome/app/theme/default_100_percent/cros/notification_peripheral_battery_low.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_200_percent/cros/notification_peripheral_battery_low.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yufeng Shen (Slow to review)
7 years, 8 months ago (2013-04-08 20:59:51 UTC) #1
Daniel Erat
lgtm
7 years, 8 months ago (2013-04-08 21:12:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/13686019/1
7 years, 8 months ago (2013-04-08 21:20:22 UTC) #3
commit-bot: I haz the power
Presubmit check for 13686019-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-08 21:20:24 UTC) #4
Daniel Erat
+oshima for rubber-stamp LGTM
7 years, 8 months ago (2013-04-08 22:09:31 UTC) #5
oshima
On 2013/04/08 22:09:31, Daniel Erat wrote: > +oshima for rubber-stamp LGTM lgtm
7 years, 8 months ago (2013-04-08 22:53:36 UTC) #6
Daniel Erat
7 years, 8 months ago (2013-04-08 22:55:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r192938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698