Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1368533004: Add UMA metrics to the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site
Patch Set: Refactor tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper.cc
diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc
index 9f78d8d2a0b0ea43c84168e66ca34da56c97d157..7f1bfe5961390c7145db1c591798936834f36878 100644
--- a/chrome/browser/engagement/site_engagement_helper.cc
+++ b/chrome/browser/engagement/site_engagement_helper.cc
@@ -46,7 +46,7 @@ bool SiteEngagementHelper::InputTracker::HandleKeyPressEvent(
// (e.g. keypress is a key down then key up).
if (event.type == blink::WebInputEvent::RawKeyDown) {
PauseTracking(helper_->web_contents()->GetRenderViewHost());
- helper_->RecordUserInput();
+ helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);
}
return false;
}
@@ -60,7 +60,7 @@ bool SiteEngagementHelper::InputTracker::HandleMouseEvent(
event.type == blink::WebInputEvent::MouseDown) ||
event.type == blink::WebInputEvent::MouseWheel) {
PauseTracking(helper_->web_contents()->GetRenderViewHost());
- helper_->RecordUserInput();
+ helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_MOUSE);
}
return false;
}
@@ -116,7 +116,8 @@ SiteEngagementHelper::SiteEngagementHelper(content::WebContents* contents)
input_tracker_(this),
record_engagement_(false) { }
-void SiteEngagementHelper::RecordUserInput() {
+void SiteEngagementHelper::RecordUserInput(
+ SiteEngagementMetrics::EngagementType type) {
TRACE_EVENT0("SiteEngagement", "RecordUserInput");
content::WebContents* contents = web_contents();
if (contents) {
@@ -127,7 +128,7 @@ void SiteEngagementHelper::RecordUserInput() {
// Service is null in incognito.
if (service)
- service->HandleUserInput(contents->GetVisibleURL());
+ service->HandleUserInput(contents->GetVisibleURL(), type);
}
}
« no previous file with comments | « chrome/browser/engagement/site_engagement_helper.h ('k') | chrome/browser/engagement/site_engagement_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698