chrome/browser/engagement/site_engagement_helper.h - Issue 1368533004: Add UMA metrics to the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.h

Issue 1368533004: Add UMA metrics to the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site

Patch Set: Addressing reviewer feedback. Adding more testing Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/engagement/site_engagement_helper.h

diff --git a/chrome/browser/engagement/site_engagement_helper.h b/chrome/browser/engagement/site_engagement_helper.h

index af059d431b24d98915c81add6e339156697d6519..bd4565009ed646d6cbf99d83d9a5eeef7fdc551e 100644

--- a/chrome/browser/engagement/site_engagement_helper.h

+++ b/chrome/browser/engagement/site_engagement_helper.h

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/timer/timer.h"

+#include "chrome/browser/engagement/site_engagement_metrics.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents_observer.h"

#include "content/public/browser/web_contents_user_data.h"

@@ -82,7 +83,7 @@ class SiteEngagementHelper

// Ask the SiteEngagementService to record engagement via user input at the

// current contents location.

- void RecordUserInput();

+ void RecordUserInput(SiteEngagementMetrics::EngagementType type);

bool ShouldRecordEngagement();

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper.cc » ('j') | chrome/browser/engagement/site_engagement_service.cc » ('J')