[Telemetry] Add an example for adding an end to end Telemetry benchmark

[Telemetry] Add an example for adding an end to end Telemetry benchmark that uses TimelineBasedMetric.

./run_benchmark --browser=system v8_latency.simple_story --use-live-sites --reset

BUG=

Committed: https://crrev.com/177be893c8e68ba6093872a511a9a2a25dabe007
Cr-Commit-Position: refs/heads/master@{#358398}

[nednguyen, 2015-09-23 23:18:18]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, eakuefner@chromium.org

[eakuefner, 2015-10-30 00:14:55]

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
File tools/telemetry/examples/benchmarks/message_loop_benchmark.py (right):

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
tools/telemetry/examples/benchmarks/message_loop_benchmark.py:19:
cat_filter.AddIncludedCategory('*')
Can we maybe expand this to first add blink.console explicitly to show that it's
required?

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
File tools/telemetry/examples/benchmarks/simple_story_set.py (right):

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
tools/telemetry/examples/benchmarks/simple_story_set.py:19:
action_runner.Wait(0.3)
I think it might be good to showcase more of what action_runner can do here.

[nednguyen, 2015-10-30 16:29:44]

Description was changed from

==========
[Telemetry] Add an example for adding an end to end Telemetry benchmark that
uses TimelineBasedMetric.

./run_benchmark --browser=system message_loop_counter.simple_story
--use-live-sites --reset

BUG=
==========

to

==========
[Telemetry] Add an example for adding an end to end Telemetry benchmark that
uses TimelineBasedMetric.

./run_benchmark --browser=system v8_latency.simple_story --use-live-sites
--reset

BUG=
==========

[nednguyen, 2015-10-30 16:29:56]

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
File tools/telemetry/examples/benchmarks/message_loop_benchmark.py (right):

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
tools/telemetry/examples/benchmarks/message_loop_benchmark.py:19:
cat_filter.AddIncludedCategory('*')
On 2015/10/30 00:14:55, eakuefner wrote:
> Can we maybe expand this to first add blink.console explicitly to show that
it's
> required?

Good call

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
File tools/telemetry/examples/benchmarks/simple_story_set.py (right):

https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
tools/telemetry/examples/benchmarks/simple_story_set.py:19:
action_runner.Wait(0.3)
On 2015/10/30 00:14:55, eakuefner wrote:
> I think it might be good to showcase more of what action_runner can do here.

Done.

[nednguyen, 2015-10-30 16:31:37]

On 2015/10/30 16:29:56, nednguyen wrote:
>
https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
> File tools/telemetry/examples/benchmarks/message_loop_benchmark.py (right):
> 
>
https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
> tools/telemetry/examples/benchmarks/message_loop_benchmark.py:19:
> cat_filter.AddIncludedCategory('*')
> On 2015/10/30 00:14:55, eakuefner wrote:
> > Can we maybe expand this to first add blink.console explicitly to show that
> it's
> > required?
> 
> Good call
> 
>
https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
> File tools/telemetry/examples/benchmarks/simple_story_set.py (right):
> 
>
https://codereview.chromium.org/1368533002/diff/1/tools/telemetry/examples/be...
> tools/telemetry/examples/benchmarks/simple_story_set.py:19:
> action_runner.Wait(0.3)
> On 2015/10/30 00:14:55, eakuefner wrote:
> > I think it might be good to showcase more of what action_runner can do here.
> 
> Done.

Looks like MessageLoop:.. no longer output by chrome trace, so I change this to
v8.

[nednguyen(REVIEW IN OTHER ACC), 2015-10-30 17:06:35]

The CQ bit was checked by nednguyen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 17:07:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368533002/20001

[commit-bot: I haz the power, 2015-10-30 18:25:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 18:25:56]

Dry run: This issue passed the CQ dry run.

[eakuefner, 2015-11-05 02:37:53]

lgtm

I'd say go ahead and land this so we can refer to it in reviews and people can
use it locally, if Kari is happy.

[aiolos (Not reviewing), 2015-11-06 18:15:21]

lgtm

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
File tools/telemetry/examples/benchmarks/__init__.py (right):

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/__init__.py:7:
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
Since this is an example, could you include a comment saying that this is the
Telemetry dir, and that it's included here so you can just import from telemetry
directly in the other files?

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
File tools/telemetry/examples/benchmarks/simple_story_set.py (right):

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/simple_story_set.py:17:
action_runner.Wait(0.5)
It might be worthwhile to add a comment about CreateInteraction as well. Since
the actions here aren't an example of a "normal" page interaction, we should
probably point out explicitly what we're wanting people to take away from this.
(ie, what actions will be in interaction records)

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/simple_story_set.py:22: # To see all the web
APIs that action_runner supports, see:
This seems like an odd place for this comment. Can it be either at the beginning
or end of this function instead?

[nednguyen, 2015-11-06 18:36:15]

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
File tools/telemetry/examples/benchmarks/__init__.py (right):

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/__init__.py:7:
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
On 2015/11/06 18:15:21, aiolos wrote:
> Since this is an example, could you include a comment saying that this is the
> Telemetry dir, and that it's included here so you can just import from
telemetry
> directly in the other files?

Done.

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
File tools/telemetry/examples/benchmarks/simple_story_set.py (right):

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/simple_story_set.py:17:
action_runner.Wait(0.5)
On 2015/11/06 18:15:21, aiolos wrote:
> It might be worthwhile to add a comment about CreateInteraction as well. Since
> the actions here aren't an example of a "normal" page interaction, we should
> probably point out explicitly what we're wanting people to take away from
this.
> (ie, what actions will be in interaction records)

Done.

https://codereview.chromium.org/1368533002/diff/20001/tools/telemetry/example...
tools/telemetry/examples/benchmarks/simple_story_set.py:22: # To see all the web
APIs that action_runner supports, see:
On 2015/11/06 18:15:21, aiolos wrote:
> This seems like an odd place for this comment. Can it be either at the
beginning
> or end of this function instead?

Done.

[nednguyen, 2015-11-06 18:36:20]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-11-06 18:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/1368533002/#ps40001
(title: "Address Kari's comments")

[commit-bot: I haz the power, 2015-11-06 18:37:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368533002/40001

[commit-bot: I haz the power, 2015-11-06 21:17:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-06 21:18:17]

Patchset 3 (id:??) landed as
https://crrev.com/177be893c8e68ba6093872a511a9a2a25dabe007
Cr-Commit-Position: refs/heads/master@{#358398}