Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 136853006: events: Add a PRESUBMIT.py script to make sure the tries run enough tests. (Closed)

Created:
6 years, 11 months ago by sadrul
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Ben Goodger (Google), M-A Ruel
Visibility:
Public.

Description

events: Add a PRESUBMIT.py script to make sure the tries run enough tests. Changes in events can affect a number of different modules, so make sure the unit-tests for at least ash, aura, events, keyboard, and views are tried on the appropriate bots (linux_aura, win, win_rel, linux_chromeos, linux_chromeos_asan). BUG=318879 R=stip@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A ui/events/PRESUBMIT.py View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
maruel@: Please review. ben@: FYI
6 years, 11 months ago (2014-01-15 20:19:17 UTC) #1
M-A Ruel
Deferring to stip@
6 years, 11 months ago (2014-01-15 20:20:54 UTC) #2
ghost stip (do not use)
lgtm
6 years, 11 months ago (2014-01-16 20:07:35 UTC) #3
sadrul
6 years, 11 months ago (2014-01-16 20:43:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r245309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698