Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: runtime/vm/isolate.cc

Issue 136853004: 1. Delete prolog weak persistent handles when shutting down an isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/isolate.h" 5 #include "vm/isolate.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "platform/json.h" 9 #include "platform/json.h"
10 #include "lib/mirrors.h" 10 #include "lib/mirrors.h"
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 724
725 // Write out profiler data if requested. 725 // Write out profiler data if requested.
726 Profiler::WriteProfile(this); 726 Profiler::WriteProfile(this);
727 727
728 // Write out the coverage data if collection has been enabled. 728 // Write out the coverage data if collection has been enabled.
729 CodeCoverage::Write(this); 729 CodeCoverage::Write(this);
730 730
731 // Finalize any weak persistent handles with a non-null referent. 731 // Finalize any weak persistent handles with a non-null referent.
732 FinalizeWeakPersistentHandlesVisitor visitor; 732 FinalizeWeakPersistentHandlesVisitor visitor;
733 api_state()->weak_persistent_handles().VisitHandles(&visitor); 733 api_state()->weak_persistent_handles().VisitHandles(&visitor);
734 api_state()->prologue_weak_persistent_handles().VisitHandles(&visitor);
734 735
735 CompilerStats::Print(); 736 CompilerStats::Print();
736 if (FLAG_trace_isolates) { 737 if (FLAG_trace_isolates) {
737 heap()->PrintSizes(); 738 heap()->PrintSizes();
738 megamorphic_cache_table()->PrintSizes(); 739 megamorphic_cache_table()->PrintSizes();
739 Symbols::DumpStats(); 740 Symbols::DumpStats();
740 OS::Print("[-] Stopping isolate:\n" 741 OS::Print("[-] Stopping isolate:\n"
741 "\tisolate: %s\n", name()); 742 "\tisolate: %s\n", name());
742 } 743 }
743 } 744 }
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 return func.raw(); 1121 return func.raw();
1121 } 1122 }
1122 1123
1123 1124
1124 void IsolateSpawnState::Cleanup() { 1125 void IsolateSpawnState::Cleanup() {
1125 SwitchIsolateScope switch_scope(isolate()); 1126 SwitchIsolateScope switch_scope(isolate());
1126 Dart::ShutdownIsolate(); 1127 Dart::ShutdownIsolate();
1127 } 1128 }
1128 1129
1129 } // namespace dart 1130 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698