Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1368493002: [sql] Fix uninit vars in Connection. (Closed)

Created:
5 years, 3 months ago by shess1
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Closed because original issue was reverted, and wrong owner for some reason.] [sql] Fix uninit vars in Connection. BUG=489784 TBR=michaeln@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sql/connection.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Scott Hess - ex-Googler
Sometimes I hate this language. Added instance vars, forgot to update constructor because I was ...
5 years, 3 months ago (2015-09-23 22:05:39 UTC) #3
michaeln
https://codereview.chromium.org/1368493002/diff/1/sql/connection.cc File sql/connection.cc (right): https://codereview.chromium.org/1368493002/diff/1/sql/connection.cc#newcode287 sql/connection.cc:287: total_changes_at_last_release_(0), lgtm maybe use c++ 11 feature that lets ...
5 years, 3 months ago (2015-09-23 22:17:22 UTC) #4
Scott Hess - ex-Googler
5 years, 3 months ago (2015-09-23 22:27:08 UTC) #5
On 2015/09/23 22:17:22, michaeln wrote:
> https://codereview.chromium.org/1368493002/diff/1/sql/connection.cc
> File sql/connection.cc (right):
> 
> https://codereview.chromium.org/1368493002/diff/1/sql/connection.cc#newcode287
> sql/connection.cc:287: total_changes_at_last_release_(0),
> lgtm
> 
> maybe use c++ 11 feature that lets you assign default values in the header?

Do we do that?  If so, maybe I'll circle back with a more comprehensive version,
as there is only one variable initialized here which actually needs to be here.

Imagine a world where you could just say "Zero fill this guy" and only
initialize the outliers.  "Don't pay for what you don't use" is fine, unless you
end up paying anyhow and you're required to use pennies.

Powered by Google App Engine
This is Rietveld 408576698