Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 136843003: Wait for SHOW_PRESS gesture to avoid flake in root_window_unittest.cc (Closed)

Created:
6 years, 11 months ago by tdresser
Modified:
6 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Wait for SHOW_PRESS gesture to avoid flake in root_window_unittest.cc Previously in RootWindowTest.TouchMovesHeld, sometimes a SHOW_PRESS gesture would be fired, and sometimes it wouldn't, depending on whether or not the 5ms timer used in tests for the SHOW_PRESS gesture was fired. Now we explicitly wait for the gesture to be fired before continuing. Marked flaky here: https://codereview.chromium.org/136013002/ TEST=RootWindowTest.TouchMovesHeld BUG=333644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245087

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase? #

Total comments: 4

Patch Set 5 : Address sadrul's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M ui/aura/root_window_unittest.cc View 1 2 3 4 6 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tdresser
PTAL.
6 years, 11 months ago (2014-01-14 16:29:50 UTC) #1
Nico
s:me:ui/aura/OWNER:
6 years, 11 months ago (2014-01-14 19:22:05 UTC) #2
sadrul
https://codereview.chromium.org/136843003/diff/100001/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/136843003/diff/100001/ui/aura/root_window_unittest.cc#newcode443 ui/aura/root_window_unittest.cc:443: void WaitUntilReceivedGesture(ui::EventType type) { Call this WaitUntilReceivedEvent https://codereview.chromium.org/136843003/diff/100001/ui/aura/root_window_unittest.cc#newcode479 ui/aura/root_window_unittest.cc:479: ...
6 years, 11 months ago (2014-01-15 19:08:59 UTC) #3
tdresser
https://codereview.chromium.org/136843003/diff/100001/ui/aura/root_window_unittest.cc File ui/aura/root_window_unittest.cc (right): https://codereview.chromium.org/136843003/diff/100001/ui/aura/root_window_unittest.cc#newcode443 ui/aura/root_window_unittest.cc:443: void WaitUntilReceivedGesture(ui::EventType type) { On 2014/01/15 19:08:59, sadrul wrote: ...
6 years, 11 months ago (2014-01-15 19:30:40 UTC) #4
sadrul
Thanks. LGTM
6 years, 11 months ago (2014-01-15 19:34:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/136843003/220001
6 years, 11 months ago (2014-01-15 21:29:09 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 03:14:13 UTC) #7
Message was sent while issue was closed.
Change committed as 245087

Powered by Google App Engine
This is Rietveld 408576698