Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1368403003: [cctest] adding tests for elements kind map migrations (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cctest] adding tests for elements kind map migrations R=mvstanton@chromium.org BUG= Committed: https://crrev.com/a9b84c1b2cd38c6e5b833833861b8506019e26ec Cr-Commit-Position: refs/heads/master@{#31080}

Patch Set 1 #

Patch Set 2 : adding file to gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -2193 lines) Patch
M test/cctest/cctest.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download
A test/cctest/test-elements-kind.cc View 1 chunk +475 lines, -0 lines 0 comments Download
A + test/cctest/test-field-type-tracking.cc View 8 chunks +14 lines, -10 lines 0 comments Download
D test/cctest/test-migrations.cc View 1 chunk +0 lines, -2182 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Camillo Bruni
PTAL
5 years, 2 months ago (2015-10-01 13:46:33 UTC) #1
mvstanton
lgtm
5 years, 2 months ago (2015-10-02 13:52:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368403003/20001
5 years, 2 months ago (2015-10-02 14:02:02 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 15:14:22 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 15:14:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9b84c1b2cd38c6e5b833833861b8506019e26ec
Cr-Commit-Position: refs/heads/master@{#31080}

Powered by Google App Engine
This is Rietveld 408576698