Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368393003: add hard-coded limit for tmp allocations when HQ image scaling (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add hard-coded limit for tmp allocations when HQ image scaling BUG=528628 Committed: https://skia.googlesource.com/skia/+/d1d4460547bcd76db7142cf9b6370dc952d459fc

Patch Set 1 #

Total comments: 2

Patch Set 2 : update dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M src/core/SkBitmapScaler.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M src/core/SkConvolver.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkConvolver.cpp View 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
reed1
ptal
5 years, 2 months ago (2015-10-01 13:40:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368393003/1
5 years, 2 months ago (2015-10-01 13:40:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 13:46:56 UTC) #6
reed1
5 years, 2 months ago (2015-10-01 14:13:44 UTC) #8
robertphillips
lgtm. It seems like we could still run in to trouble even with this hard ...
5 years, 2 months ago (2015-10-01 15:01:09 UTC) #9
reed1
https://codereview.chromium.org/1368393003/diff/1/src/core/SkConvolver.h File src/core/SkConvolver.h (right): https://codereview.chromium.org/1368393003/diff/1/src/core/SkConvolver.h#newcode195 src/core/SkConvolver.h:195: // (this is ARGB when loaded into 32-bit words ...
5 years, 2 months ago (2015-10-01 18:14:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368393003/20001
5 years, 2 months ago (2015-10-01 18:15:09 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 18:22:04 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1d4460547bcd76db7142cf9b6370dc952d459fc

Powered by Google App Engine
This is Rietveld 408576698