Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

Issue 1368383002: Need to handle skipping mixins in a CustomElement (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
index c97d4f5cc09f7417cadb7be5ab24b6f4ad4a5578..0a0ff4c67eb00b0c0c5a5615eca7cc11313214d2 100644
--- a/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
+++ b/tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate
@@ -282,7 +282,7 @@ $if DARTIUM
// Get the created constructor source and look at the initializer;
// Must call super.created() if not its as an error.
- var createdSource = methodMirror.source.replaceAll('\n', ' ');
+ var createdSource = methodMirror.source?.replaceAll('\n', ' ');
RegExp regExp = new RegExp(r":(.*?)(;|}|\n)");
var match = regExp.firstMatch(createdSource);
superCreatedCalled = match.input.substring(match.start,match.end).contains("super.created(");
@@ -295,6 +295,10 @@ $if DARTIUM
}
classMirror = classMirror.superclass;
+ while (classMirror != classMirror.mixin) {
+ // Skip the mixins.
+ classMirror = classMirror.superclass;
+ }
}
return true;
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698