Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1368373002:
Add policy templates for URL filtering on WebView (Closed)
DescriptionAdd policy templates for URL filtering on WebView
BUG=536733
Committed: https://crrev.com/612eb8e6558368f85c8893cd156fea2152a111c2
Cr-Commit-Position: refs/heads/master@{#359834}
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Add webview_android to the supported product names #Messages
Total messages: 23 (9 generated)
dgn@chromium.org changed reviewers: + bartfab@chromium.org
Follow up to https://codereview.chromium.org/1372953002/
bauerb@chromium.org changed reviewers: + bauerb@chromium.org
lgtm
Thanks. bartfab@: This has been reviewed by bauerb@. Could you please rubberstamp?
The CQ bit was checked by dgn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368373002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by dgn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368373002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
dgn@chromium.org changed reviewers: + atwilson@chromium.org
atwilson@: CL was reviewed by bauerb@ and passes the trybots. Could you rubberstamp please?
https://codereview.chromium.org/1368373002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/1368373002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:91: # 'chrome.win', 'chrome.linux', 'chrome.mac', 'chrome.*' Should you document the new webview_android type here?
PTAL https://codereview.chromium.org/1368373002/diff/20001/components/policy/resou... File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/1368373002/diff/20001/components/policy/resou... components/policy/resources/policy_templates.json:91: # 'chrome.win', 'chrome.linux', 'chrome.mac', 'chrome.*' On 2015/11/13 13:59:23, Andrew T Wilson (Slow) wrote: > Should you document the new webview_android type here? Thanks, I missed that. The documentation does not mention anything else android related so I thing we're fine.
lgtm
The CQ bit was checked by dgn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/1368373002/#ps40001 (title: "Add webview_android to the supported product names")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368373002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/612eb8e6558368f85c8893cd156fea2152a111c2 Cr-Commit-Position: refs/heads/master@{#359834} |
