Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2545)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 1368363003: Programmatically render the omnibox border (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index b0ef71c4d045b0090f81800a40932018fa3d68c5..47f8a54a72f8c5716e803a78a8b66c5f32a64fef 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -187,7 +187,7 @@ void LocationBarView::Init() {
IMAGE_GRID(IDR_OMNIBOX_POPUP_BORDER_AND_SHADOW);
border_painter_.reset(
views::Painter::CreateImageGridPainter(kOmniboxPopupBorderImages));
- } else {
+ } else if (!ui::MaterialDesignController::IsModeMaterial()) {
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
const gfx::Insets omnibox_border_insets(14, 9, 14, 9);
border_painter_.reset(views::Painter::CreateImagePainter(
@@ -528,11 +528,13 @@ void LocationBarView::GetAccessibleState(ui::AXViewState* state) {
gfx::Size LocationBarView::GetPreferredSize() const {
// Compute minimum height.
- gfx::Size min_size(border_painter_->GetMinimumSize());
+ gfx::Size min_size;
// For non-material the size of the asset determines the size of the
// LocationBarView.
if (ui::MaterialDesignController::IsModeMaterial())
min_size.set_height(GetLayoutConstant(LOCATION_BAR_HEIGHT));
+ else
+ min_size = border_painter_->GetMinimumSize();
if (!IsInitialized())
return min_size;
@@ -1273,8 +1275,31 @@ void LocationBarView::PaintChildren(const ui::PaintContext& context) {
gfx::Rect border_rect(GetContentsBounds());
if (is_popup_mode_ && (GetHorizontalEdgeThickness() == 0))
border_rect.Inset(-kPopupEdgeThickness, 0);
- views::Painter::PaintPainterAt(recorder.canvas(), border_painter_.get(),
- border_rect);
+
+ if (ui::MaterialDesignController::IsModeMaterial()) {
+ recorder.canvas()->Save();
+ SkScalar scale_factor = 1.0f / recorder.canvas()->image_scale();
+ recorder.canvas()->sk_canvas()->scale(scale_factor, scale_factor);
+
+ SkPaint paint;
+ paint.setStyle(SkPaint::Style::kStroke_Style);
+ paint.setColor(SkColorSetARGBInline(0x40, 0x0, 0x0, 0x0));
+ paint.setStrokeWidth(0);
+ paint.setAntiAlias(true);
+
+ const float kOffset = 0.5f;
+ gfx::RectF border_rect_f(border_rect);
+ gfx::InsetsF insets(kOffset, kOffset, kOffset, kOffset);
+ border_rect_f.Inset(insets);
+
+ const SkScalar kCornerRadius = SkDoubleToScalar(2.5f);
+ recorder.canvas()->sk_canvas()->drawRoundRect(
+ gfx::RectFToSkRect(border_rect_f), kCornerRadius, kCornerRadius, paint);
+ recorder.canvas()->Restore();
+ } else {
+ views::Painter::PaintPainterAt(recorder.canvas(), border_painter_.get(),
+ border_rect);
+ }
}
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698