Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1368363002: Fix automake files after README.md -> README rename (Closed)

Created:
5 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix automake files after README.md -> README rename Minor followup to crrev.com/1357773004 and crrev.com/1361993002 which moved the README and forgot to update the automake files. This is to make "./configure && make" work. TBR=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/9d3e1f1c035ad4d4c31d289fdba279bec047d03a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Makefile.am View 1 chunk +1 line, -1 line 0 comments Download
M Makefile.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Primiano Tucci (use gerrit)
Mark, TBR-ing this 2 line change. Just cleaning up makefiles to make ./configure and make ...
5 years, 2 months ago (2015-09-28 13:01:55 UTC) #2
Primiano Tucci (use gerrit)
Committed patchset #1 (id:1) manually as 9d3e1f1c035ad4d4c31d289fdba279bec047d03a (presubmit successful).
5 years, 2 months ago (2015-09-28 13:02:13 UTC) #3
Ted Mielczarek
lgtm
5 years, 2 months ago (2015-09-28 13:43:08 UTC) #5
Ted Mielczarek
(And thanks, I hit this too. We should get some public-facing CI...)
5 years, 2 months ago (2015-09-28 13:43:31 UTC) #6
Mark Mentovai
Primiano Tucci wrote: > This CL reminds me: > http://ecx.images-amazon.com/images/I/41cA94UUuXL._SY344_BO1,204,203,200_.jpg :) LGTM
5 years, 2 months ago (2015-09-28 13:52:30 UTC) #7
vapier
meh, i don't think there's any realistic alternatives to autotools here
5 years, 2 months ago (2015-09-28 15:37:22 UTC) #8
Primiano Tucci (use gerrit)
On 2015/09/28 15:37:22, vapier wrote: > meh, i don't think there's any realistic alternatives to ...
5 years, 2 months ago (2015-09-28 15:38:30 UTC) #9
vapier
not really. i've used plenty of other build systems, so i'm pretty aware of their ...
5 years, 2 months ago (2015-09-28 15:52:36 UTC) #11
Ted Mielczarek
5 years, 2 months ago (2015-09-28 16:14:03 UTC) #12
Message was sent while issue was closed.
On 2015/09/28 15:52:36, vapier wrote:
> not really.  i've used plenty of other build systems, so i'm pretty aware of
> their capabilities, especially when it comes to portability and
> cross-compilation.  while autotools is not generally easy and has a history of
> users cargo-culting code around, it's still the best imo in those two aspects.

> most newer build systems focus on a subset of these requirements.

This is pretty much true. I'm hoping someone will fix up bazel to be a realistic
alternative...

Powered by Google App Engine
This is Rietveld 408576698