Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368333004: Move Mutexy things to private. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move Mutexy things to private. There is no API change. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/62a69c26b3a34c259918d6c97b4dea76b6285b67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -314 lines) Patch
M bench/RefCntBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/core.gypi View 2 chunks +8 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D include/core/SkMutex.h View 1 chunk +0 lines, -122 lines 0 comments Download
D include/core/SkOnce.h View 1 chunk +0 lines, -139 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
D include/core/SkSpinlock.h View 1 chunk +0 lines, -44 lines 0 comments Download
M include/effects/SkColorCubeFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrResourceKey.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkMutex.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkOnce.h View 1 chunk +1 line, -1 line 0 comments Download
A + include/private/SkSpinlock.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/core/SkSharedMutex.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/skia_test.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368333004/1
5 years, 2 months ago (2015-09-29 18:10:12 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 18:17:14 UTC) #4
herb_g
5 years, 2 months ago (2015-09-29 18:18:58 UTC) #6
mtklein
lgtm
5 years, 2 months ago (2015-09-29 18:43:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368333004/1
5 years, 2 months ago (2015-09-29 18:43:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368333004/1
5 years, 2 months ago (2015-09-29 18:44:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2925)
5 years, 2 months ago (2015-09-29 18:45:01 UTC) #13
herb_g
5 years, 2 months ago (2015-09-29 18:46:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368333004/1
5 years, 2 months ago (2015-09-29 18:47:02 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 18:47:48 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/62a69c26b3a34c259918d6c97b4dea76b6285b67

Powered by Google App Engine
This is Rietveld 408576698