Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1368313005: Missing clear() for pseudo invalidation sets. (Closed)

Created:
5 years, 2 months ago by rune
Modified:
5 years, 2 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Missing clear() for pseudo invalidation sets. Missing clear in RuleFeatureSet::clear caused rules removed from shadow trees to still affect invalidation after removal. R=sigbjornf@opera.com BUG=538586 Committed: https://crrev.com/91a26ed83a4e0caaf54bf0e33d84ca29ebb25317 Cr-Commit-Position: refs/heads/master@{#352278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/removed-hover-shadow-rule-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rune
5 years, 2 months ago (2015-10-04 11:22:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368313005/1
5 years, 2 months ago (2015-10-04 11:23:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-04 12:55:46 UTC) #5
sof
lgtm
5 years, 2 months ago (2015-10-04 20:36:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368313005/1
5 years, 2 months ago (2015-10-04 20:36:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-04 20:40:38 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-04 20:41:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91a26ed83a4e0caaf54bf0e33d84ca29ebb25317
Cr-Commit-Position: refs/heads/master@{#352278}

Powered by Google App Engine
This is Rietveld 408576698