Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368263002: Separate out compiler and runtime configs on Windows and Android GN. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Nico, Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate out compiler and runtime configs on Windows and Android GN. This should be a NOP from a build setup perspective, but aims to make the large common shared build configuration files easier to understand. Committed: https://crrev.com/a43e85a1b6cfa9833e4ab5b8d286989f9204523d Cr-Commit-Position: refs/heads/master@{#351015}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -204 lines) Patch
M build/config/android/BUILD.gn View 1 2 chunks +100 lines, -26 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 4 chunks +20 lines, -173 lines 0 comments Download
M build/config/win/BUILD.gn View 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
brettw
https://codereview.chromium.org/1368263002/diff/1/build/config/android/BUILD.gn File build/config/android/BUILD.gn (left): https://codereview.chromium.org/1368263002/diff/1/build/config/android/BUILD.gn#oldcode11 build/config/android/BUILD.gn:11: config("sdk") { This just moved to the bottom so ...
5 years, 2 months ago (2015-09-27 23:42:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368263002/1
5 years, 2 months ago (2015-09-27 23:42:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/137524)
5 years, 2 months ago (2015-09-27 23:47:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368263002/20001
5 years, 2 months ago (2015-09-28 01:17:21 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 01:46:02 UTC) #10
Bons
lgtm lgtm
5 years, 2 months ago (2015-09-28 02:26:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368263002/20001
5 years, 2 months ago (2015-09-28 02:26:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 02:32:44 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a43e85a1b6cfa9833e4ab5b8d286989f9204523d Cr-Commit-Position: refs/heads/master@{#351015}
5 years, 2 months ago (2015-09-28 02:33:34 UTC) #15
Nico
this broke the win/clang build: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/2015/steps/generate_build_files/logs/stdio i'll send you a cl to fix
5 years, 2 months ago (2015-09-28 09:35:34 UTC) #17
brettw
On 2015/09/28 09:35:34, Nico (offline until Fri Oct 9) wrote: > this broke the win/clang ...
5 years, 2 months ago (2015-09-28 20:00:11 UTC) #18
agrieve
On 2015/09/28 20:00:11, brettw wrote: > On 2015/09/28 09:35:34, Nico (offline until Fri Oct 9) ...
5 years, 2 months ago (2015-10-01 19:47:00 UTC) #19
agrieve
5 years, 2 months ago (2015-10-01 19:47:16 UTC) #20
Message was sent while issue was closed. 
On 2015/10/01 19:47:00, agrieve wrote:
> On 2015/09/28 20:00:11, brettw wrote:
> > On 2015/09/28 09:35:34, Nico (offline until Fri Oct 9) wrote:
> > > this broke the win/clang build:
> > >
> >
>
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/build...
> > > 
> > > i'll send you a cl to fix
> > 
> > okay, sorry!
> 
> This also broke android :(. will try to figure out the fix.

https://code.google.com/p/chromium/issues/detail?id=537313

Powered by Google App Engine
This is Rietveld 408576698