third_party/WebKit/LayoutTests/fast/table/colspan-with-empty-cells-needing-extra-width.html - Issue 1368243002: Don't deduct min-width from the available width for empty cells

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/colspan-with-empty-cells-needing-extra-width.html

Issue 1368243002: Don't deduct min-width from the available width for empty cells (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/colspan-with-empty-cells-needing-extra-width-expected.html » ('j') | third_party/WebKit/Source/core/layout/TableLayoutAlgorithmAuto.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table td {

	4 padding: 0;

	5 margin: 0;
	mstensho (USE GERRIT) 2015/09/30 11:09:39 No UA-defined margins on those elements. No UA-defined margins on those elements.
	6 }

	7 </style>

	8 <p>crbug.com/534830: Don't deduct the min-width of empty cells from the availabl e table width. </p>
	mstensho (USE GERRIT) 2015/09/30 11:09:39 Can you please write a test with a human readable Can you please write a test with a human readable and observable pass condition? It also seems that it should be easy to write a check-layout.js test instead. Those run much faster.
	9 <table style="width: 800px; background-color: black;">
	mstensho (USE GERRIT) 2015/09/30 11:09:39 This is wider than the initial viewport when start This is wider than the initial viewport when starting content_shell. Use width:100% instead?
	10 <tr>

	11 <td style="background-color:red; width: 10px; height:20px;"></td>
	mstensho (USE GERRIT) 2015/09/30 11:09:39 Red means danger. Maybe set the background of the Red means danger. Maybe set the background of the table to red instead, set its border-spacing to 0 and have "no red" as part of the pass condition?
	12 <td style="background-color:blue;"></td>

	13 </tr>

	14 <tr>

	15 <td colspan="2" style="background-color:yellow;">

	16 TestTestTest

	17 </td>

	18 </tr>

	19 </table>

OLD	NEW