Issue 136823002: Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_try

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136823002: Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_try (Closed)

Created:
6 years, 11 months ago by borenet

Modified:
6 years, 11 months ago

Reviewers:
epoger, rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_try BUG=skia:1862 R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=13066

Patch Set 4 : retry upload #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	tools/submit_try	View	1 2	3 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

Will submit this if it fixes http://code.google.com/p/skia/issues/detail?id=1862

6 years, 11 months ago (2014-01-13 20:17:30 UTC) #1

epoger

LGTM if it works https://codereview.chromium.org/136823002/diff/30001/tools/submit_try File tools/submit_try (right): https://codereview.chromium.org/136823002/diff/30001/tools/submit_try#newcode272 tools/submit_try:272: # Find depot_tools. This is ...

6 years, 11 months ago (2014-01-13 20:44:53 UTC) #2

borenet

Uploaded patch set 4. Going ahead and submitting, since this is better than it was, ...

6 years, 11 months ago (2014-01-14 18:03:02 UTC) #3

borenet

6 years, 11 months ago (2014-01-14 18:03:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r13066 (presubmit successful).

Expand Messages | Collapse Messages

Issue 136823002: Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_try (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : retry upload #

Messages