Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 1368223002: [GN]: BUILD file housecleaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index b7dace7ab0afcee76a7e287501c2d3e6374fe0e9..ae46760059fff7fbb1e7dadb27351a3af1188ccd 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -420,16 +420,12 @@ void NinjaBinaryTargetWriter::WriteCompilerVars(
WriteOneFlag(SUBSTITUTION_ASMFLAGS, false, Toolchain::TYPE_NONE,
&ConfigValues::asmflags, opts);
}
- // TODO(andybons): Remove SOURCE_S and SOURCE_ASM checks once asmflags is
- // used.
if (used_types.Get(SOURCE_C) || used_types.Get(SOURCE_CPP) ||
- used_types.Get(SOURCE_M) || used_types.Get(SOURCE_MM) ||
- used_types.Get(SOURCE_S) || used_types.Get(SOURCE_ASM)) {
+ used_types.Get(SOURCE_M) || used_types.Get(SOURCE_MM)) {
WriteOneFlag(SUBSTITUTION_CFLAGS, false, Toolchain::TYPE_NONE,
&ConfigValues::cflags, opts);
}
- if (used_types.Get(SOURCE_C) || used_types.Get(SOURCE_S) ||
- used_types.Get(SOURCE_ASM)) {
+ if (used_types.Get(SOURCE_C)) {
WriteOneFlag(SUBSTITUTION_CFLAGS_C, has_precompiled_headers,
Toolchain::TYPE_CC, &ConfigValues::cflags_c, opts);
}
« no previous file with comments | « build/toolchain/win/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698