[GN]: BUILD file housecleaning

build/config/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/win/visual_studio_version.gni")
 
 assert(is_win)
 
@@ skipping 111 matching lines @@
     "_WINDOWS",
     "CERT_CHAIN_PARA_HAS_EXTRA_FIELDS",
     "NTDDI_VERSION=0x06030000",
     "PSAPI_VERSION=1",
     "WIN32",
     "_SECURE_ATL",
 
     # This is required for ATL to use XP-safe versions of its functions.
     "_USING_V110_SDK71_",
   ]
+
+  asmflags = [
+    # When /SAFESEH is specified, the linker will only produce an image if it
+    # can also produce a table of the image's safe exception handlers. This
+    # table specifies for the operating system which exception handlers are
+    # valid for the image.
+    "/SAFESEH",

[brettw, 2015/09/28 19:44:52]

This didn't seem to come from anywhere else. I'm assuming you noticed this was
needed for some reason? Can this reason be added to the commit message?

Also, should this go on the compiler config above instead?

[Bons, 2015/09/28 20:15:39]

It came from the windows toolchain config where it was hardcoded.
Done.

+  ]
 }
 
 # Sets the default Windows build version. This is separated because some
 # targets need to manually override it for their compiles.
 config("winver") {
   defines = [
     "_WIN32_WINNT=0x0603",
     "WINVER=0x0603",
   ]
 }
@@ skipping 163 matching lines @@
 
 # Internal stuff --------------------------------------------------------------
 
 # Config used by the MIDL template to disable warnings.
 config("midl_warnings") {
   if (is_clang) {
     # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
     cflags = [ "-Wno-extra-tokens" ]
   }
 }