Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: build/toolchain/win/BUILD.gn

Issue 1368223002: [GN]: BUILD file housecleaning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Path to the directory containing the VC binaries for the right 6 # Path to the directory containing the VC binaries for the right
7 # combination of host and target architectures. Currently only the 7 # combination of host and target architectures. Currently only the
8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets. 8 # 64-bit host toolchain is supported, with either 32-bit or 64-bit targets.
9 # If vc_bin_dir is not specified on the command line (and it normally 9 # If vc_bin_dir is not specified on the command line (and it normally
10 # isn't), we will dynamically determine the right value to use at runtime. 10 # isn't), we will dynamically determine the right value to use at runtime.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 tool("rc") { 114 tool("rc") {
115 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}" 115 command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{ include_dirs}} /fo{{output}} {{source}}"
116 outputs = [ 116 outputs = [
117 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res", 117 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.res",
118 ] 118 ]
119 description = "RC {{output}}" 119 description = "RC {{output}}"
120 } 120 }
121 121
122 tool("asm") { 122 tool("asm") {
123 # TODO(brettw): "/safeseh" assembler argument is hardcoded here. Extract 123 command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} { {include_dirs}} {{asmflags}} /c /Fo{{output}} {{source}}"
124 # assembler flags to a variable like cflags. crbug.com/418613
125 command = "$python_path gyp-win-tool asm-wrapper $env ml.exe {{defines}} { {include_dirs}} /safeseh /c /Fo {{output}} {{source}}"
126 description = "ASM {{output}}" 124 description = "ASM {{output}}"
127 outputs = [ 125 outputs = [
128 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj", 126 "{{target_out_dir}}/{{target_output_name}}/{{source_name_part}}.obj",
129 ] 127 ]
130 } 128 }
131 129
132 tool("alink") { 130 tool("alink") {
133 rspfile = "{{output}}.rsp" 131 rspfile = "{{output}}.rsp"
134 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile" 132 command = "$python_path gyp-win-tool link-wrapper $env False lib.exe /nolo go /ignore:4221 /OUT:{{output}} @$rspfile"
135 description = "LIB {{output}}" 133 description = "LIB {{output}}"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 } 269 }
272 270
273 msvc_toolchain("winrt_x64") { 271 msvc_toolchain("winrt_x64") {
274 environment = "environment.winrt_x64" 272 environment = "environment.winrt_x64"
275 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\"" 273 cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
276 is_clang = false 274 is_clang = false
277 275
278 current_cpu = "x64" 276 current_cpu = "x64"
279 current_os = current_os 277 current_os = current_os
280 } 278 }
OLDNEW
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698