Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1368213004: Consume whitespace at start of calc subexpression (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consume whitespace at start of calc subexpression Consume whitespace at start of calc subexpression, just like we do for the overall calc expression. This fixes the indiloop login page. BUG=537573 Committed: https://crrev.com/7bb8c25b4e763779e29cd592216ed92b2b140e0d Cr-Commit-Position: refs/heads/master@{#352418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/css3/calc/simple-calcs.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/css3/calc/simple-calcs-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
rwlbuis
PTAL.
5 years, 2 months ago (2015-10-04 21:57:41 UTC) #2
rwlbuis
Adding skobes since it would be nice if this made the cutoff :) Note that ...
5 years, 2 months ago (2015-10-05 13:50:11 UTC) #4
skobes
lgtm Thanks for the fix!
5 years, 2 months ago (2015-10-05 15:03:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368213004/1
5 years, 2 months ago (2015-10-05 15:05:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/78124)
5 years, 2 months ago (2015-10-05 15:14:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368213004/1
5 years, 2 months ago (2015-10-05 18:44:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 20:50:57 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:52:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bb8c25b4e763779e29cd592216ed92b2b140e0d
Cr-Commit-Position: refs/heads/master@{#352418}

Powered by Google App Engine
This is Rietveld 408576698