Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: pkg/analysis_server/lib/src/services/completion/uri_contributor.dart

Issue 1368173004: add completion after export - fixes #24400 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/uri_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/uri_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/uri_contributor.dart b/pkg/analysis_server/lib/src/services/completion/uri_contributor.dart
index cb32012f64a274bf9b227dfb32b4c56869f52005..3246de2f43bb9516c72c3721c37b68bf3288fd87 100644
--- a/pkg/analysis_server/lib/src/services/completion/uri_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/uri_contributor.dart
@@ -48,13 +48,22 @@ class _UriSuggestionBuilder extends SimpleAstVisitor {
}
@override
+ visitExportDirective(exportDirective node) {
+ visitNamespaceDirective(node);
+ }
+
+ @override
visitImportDirective(ImportDirective node) {
+ visitNamespaceDirective(node);
+ }
+
+ visitNamespaceDirective(NamespaceDirective node) {
StringLiteral uri = node.uri;
if (uri is SimpleStringLiteral) {
int offset = request.offset;
if (uri.offset < offset &&
(offset < uri.end || offset == uri.offset + 1)) {
- // Handle degenerate case where import is only line in file
+ // Handle degenerate case where import or export is only line in file
// and there is no semicolon
visitSimpleStringLiteral(uri);
}
@@ -64,7 +73,7 @@ class _UriSuggestionBuilder extends SimpleAstVisitor {
@override
visitSimpleStringLiteral(SimpleStringLiteral node) {
AstNode parent = node.parent;
- if (parent is ImportDirective && parent.uri == node) {
+ if (parent is NamespaceDirective && parent.uri == node) {
String partial = node.literal.lexeme.substring(
node.contentsOffset - node.offset, request.offset - node.offset);
request.replacementOffset = node.contentsOffset;
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/uri_contributor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698