Do not eagerly finalize when optimizing. Remove allocation of temporary strings in new space.

runtime/vm/flow_graph_optimizer.cc

Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index 54a571a44ddc36a3c8e19ed516a0c0c262a3c1ce..2de1e6931465800448518ed483995ae0d30fc2ef 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -224,6 +224,10 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
     ArgumentsDescriptor args_desc(args_desc_array);
     const Class& receiver_class = Class::Handle(Z,
         isolate()->class_table()->At(class_ids[0]));
+    if (!receiver_class.is_finalized()) {
+      // Do not eagerly finalize classes.

[regis, 2015/09/25 20:55:24]

I do not see how we were finalizing before.

[srdjan, 2015/09/25 21:15:59]

Added to comment:

Callee's receiver class may not be finalized yet. ResolveDynamicForReceiverClass
can cause class finalization, since callee's receiver class may not be finalized
yet.

+      return false;
+    }
     const Function& function = Function::Handle(Z,
         Resolver::ResolveDynamicForReceiverClass(
             receiver_class,