Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1368153003: Cleanup CJBig2_ArithDecoder. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Rename member variables #

Patch Set 2 : Refactor code #

Total comments: 3

Patch Set 3 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -77 lines) Patch
M core/src/fxcodec/jbig2/JBig2_ArithDecoder.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp View 1 2 2 chunks +57 lines, -71 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
5 years, 2 months ago (2015-09-28 17:29:44 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1368153003/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp File core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp (right): https://codereview.chromium.org/1368153003/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp#newcode79 core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp:79: int D = 1 - pCX->MPS; Nit: not ...
5 years, 2 months ago (2015-09-29 17:56:50 UTC) #3
Lei Zhang
https://codereview.chromium.org/1368153003/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp File core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp (right): https://codereview.chromium.org/1368153003/diff/20001/core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp#newcode79 core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp:79: int D = 1 - pCX->MPS; On 2015/09/29 17:56:50, ...
5 years, 2 months ago (2015-09-30 04:14:44 UTC) #5
Lei Zhang
5 years, 2 months ago (2015-09-30 04:15:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
0fef7dd405ac85660dbeddd2e47620daffa70cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698