Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1368153002: [js] simplify qualified names (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M lib/src/codegen/js_codegen.dart View 5 chunks +20 lines, -19 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
Simplifies qualified names ... mainly that they don't take a JS.Expression anymore. We also don't ...
5 years, 2 months ago (2015-09-25 19:49:00 UTC) #2
vsm
lgtm
5 years, 2 months ago (2015-09-25 19:51:15 UTC) #3
Jennifer Messerly
5 years, 2 months ago (2015-09-25 20:04:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1549e6a5e7e07a7f0ccb630dbaa9260718acb460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698