Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1368133002:
AIX's cp command does not support -af which is the default, so use -RPf which achives something sim… (Closed)
|
Created:
5 years, 2 months ago by David Edelsohn Modified:
5 years, 2 months ago CC:
gyp-developer_googlegroups.com Base URL:
https://chromium.googlesource.com/external/gyp.git@master Target Ref:
refs/heads/master Project:
gyp Visibility:
Public. |
DescriptionAIX's cp command does not support -af which is the default, so use -RPf which achives something similar
BUG=
R=kjellander@chromium.org
Committed: https://chromium.googlesource.com/external/gyp/+/b3cef028a51a2313ca4bc34f437b945ff56ffb9a
Patch Set 1 #
Total comments: 2
Patch Set 2 : AIX cp command line arguments update #Messages
Total messages: 14 (2 generated)
dje.gcc@gmail.com changed reviewers: + hablich@chromium.org, thakis@chromium.org
hablich@chromium.org changed reviewers: + kjellander@chromium.org
On 2015/10/05 12:18:33, Hablich wrote: > mailto:hablich@chromium.org changed reviewers: > + mailto:kjellander@chromium.org I added kjellander.
lgtm, but I'm not an OWNER. Do you have a BUG#?
On 2015/10/05 12:26:25, kjellander (chromium) wrote: > lgtm, but I'm not an OWNER. > > Do you have a BUG#? We did not create an external BUG in Chromium prior to creating the Issue and upload. Is v8 planning to move to the replacement for Gyp?
On 2015/10/05 13:50:05, David Edelsohn wrote: > On 2015/10/05 12:26:25, kjellander (chromium) wrote: > > lgtm, but I'm not an OWNER. > > > > Do you have a BUG#? > > We did not create an external BUG in Chromium prior to creating the Issue and > upload. > > Is v8 planning to move to the replacement for Gyp? Yes, but there is no ETA yet.
https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' don't use a variable for this, it's never really read more than once https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' do you want -p too? or does aix not have that either?
On 2015/10/08 02:30:14, Nico (offline until Fri Oct 9) wrote: > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py > File pylib/gyp/generator/make.py (right): > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' > don't use a variable for this, it's never really read more than once I'm confused about the preferred style. Why is flock_command a variable but copy_archive_arguments shouldn't be? I was trying to be consistent with the rest of the file. > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' > do you want -p too? or does aix not have that either? AIX cp supports the "-p" command line option. I can add that.
On 2015/10/08 19:02:01, David Edelsohn wrote: > On 2015/10/08 02:30:14, Nico (offline until Fri Oct 9) wrote: > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py > > File pylib/gyp/generator/make.py (right): > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' > > don't use a variable for this, it's never really read more than once > > I'm confused about the preferred style. Why is flock_command a variable but > copy_archive_arguments shouldn't be? I was trying to be consistent with the rest > of the file. > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' > > do you want -p too? or does aix not have that either? > > AIX cp supports the "-p" command line option. I can add that. '-pPRf' also works.
On 2015/10/08 19:45:41, David Edelsohn wrote: > On 2015/10/08 19:02:01, David Edelsohn wrote: > > On 2015/10/08 02:30:14, Nico (offline until Fri Oct 9) wrote: > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py > > > File pylib/gyp/generator/make.py (right): > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' > > > don't use a variable for this, it's never really read more than once > > > > I'm confused about the preferred style. Why is flock_command a variable but > > copy_archive_arguments shouldn't be? I was trying to be consistent with the > rest > > of the file. > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' > > > do you want -p too? or does aix not have that either? > > > > AIX cp supports the "-p" command line option. I can add that. > > '-pPRf' also works. Is this waiting on an update or agreement on to change it to -pPRf ?
On 2015/10/15 23:55:44, michael_dawson wrote: > On 2015/10/08 19:45:41, David Edelsohn wrote: > > On 2015/10/08 19:02:01, David Edelsohn wrote: > > > On 2015/10/08 02:30:14, Nico (offline until Fri Oct 9) wrote: > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py > > > > File pylib/gyp/generator/make.py (right): > > > > > > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > > pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' > > > > don't use a variable for this, it's never really read more than once > > > > > > I'm confused about the preferred style. Why is flock_command a variable but > > > copy_archive_arguments shouldn't be? I was trying to be consistent with the > > rest > > > of the file. > > > > > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > > pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' > > > > do you want -p too? or does aix not have that either? > > > > > > AIX cp supports the "-p" command line option. I can add that. > > > > '-pPRf' also works. > > Is this waiting on an update or agreement on to change it to -pPRf ? That's my understanding at least, yes.
On 2015/10/16 04:09:36, Nico wrote: > On 2015/10/15 23:55:44, michael_dawson wrote: > > On 2015/10/08 19:45:41, David Edelsohn wrote: > > > On 2015/10/08 19:02:01, David Edelsohn wrote: > > > > On 2015/10/08 02:30:14, Nico (offline until Fri Oct 9) wrote: > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py > > > > > File pylib/gyp/generator/make.py (right): > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > > > pylib/gyp/generator/make.py:2013: copy_archive_arguments = '-af' > > > > > don't use a variable for this, it's never really read more than once > > > > > > > > I'm confused about the preferred style. Why is flock_command a variable > but > > > > copy_archive_arguments shouldn't be? I was trying to be consistent with > the > > > rest > > > > of the file. > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/1368133002/diff/1/pylib/gyp/generator/make.py... > > > > > pylib/gyp/generator/make.py:2048: copy_archive_arguments = '-R -P -f' > > > > > do you want -p too? or does aix not have that either? > > > > > > > > AIX cp supports the "-p" command line option. I can add that. > > > > > > '-pPRf' also works. > > > > Is this waiting on an update or agreement on to change it to -pPRf ? > > That's my understanding at least, yes. I thought that I had uploaded the revised patch. Please find Patch Set 2. Note that I cannot land the patch.
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as b3cef028a51a2313ca4bc34f437b945ff56ffb9a (presubmit successful).
Message was sent while issue was closed.
Committed. Thanks for the patch! |
