Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1368113002: Allow zero inputs for feMerge (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow zero inputs for feMerge An feMerge which doesn't have any inputs should simply produce no output (rather than failing the filter chain.) Both FEMerge (w/ minor tweak) and SkMergeImageFilter are able to cope with this case. Any single-input primitives that sources from the merge will also not produce any output. This behavior actually matches Gecko, and the spec is not very outspoken on the matter. BUG=533457 Committed: https://crrev.com/d3eeee8b67656cd6a031a0ea7abbe2a49fbc892b Cr-Commit-Position: refs/heads/master@{#350884}

Patch Set 1 #

Patch Set 2 : Rebase; Drop assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/css3/filters/effect-reference-merge-no-inputs.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/filters/effect-reference-merge-no-inputs-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
5 years, 2 months ago (2015-09-25 18:01:43 UTC) #2
pdr.
lgtm
5 years, 2 months ago (2015-09-25 18:05:48 UTC) #4
f(malita)
lgtm
5 years, 2 months ago (2015-09-25 18:05:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368113002/20001
5 years, 2 months ago (2015-09-25 18:06:53 UTC) #6
Stephen White
LGTM
5 years, 2 months ago (2015-09-25 18:10:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 19:28:32 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 19:30:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3eeee8b67656cd6a031a0ea7abbe2a49fbc892b
Cr-Commit-Position: refs/heads/master@{#350884}

Powered by Google App Engine
This is Rietveld 408576698