Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1368103002: Revert of [heap] Move large object space selection into AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Move large object space selection into AllocateRaw. (patchset #1 id:1 of https://codereview.chromium.org/1360903004/ ) Reason for revert: [Sheriff] Breaks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/2080 And maybe (not sure): http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/1529 Original issue's description: > [heap] Move large object space selection into AllocateRaw. > > BUG= > > Committed: https://crrev.com/1403815bdbcbd3336b2d85291704640fada30ffe > Cr-Commit-Position: refs/heads/master@{#30930} TBR=mlippautz@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f746d35775f429c0e2d86c605c250d75048e6020 Cr-Commit-Position: refs/heads/master@{#30931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M src/heap/heap.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +15 lines, -12 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [heap] Move large object space selection into AllocateRaw.
5 years, 2 months ago (2015-09-25 11:27:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1368103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1368103002/1
5 years, 2 months ago (2015-09-25 11:27:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 11:27:48 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:27:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f746d35775f429c0e2d86c605c250d75048e6020
Cr-Commit-Position: refs/heads/master@{#30931}

Powered by Google App Engine
This is Rietveld 408576698