Issue 1368023004: Use references instead of pointers for CPU context in SimulateCrash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1368023004: Use references instead of pointers for CPU context in SimulateCrash (Closed)

Created:
5 years, 2 months ago by Mark Mentovai

Modified:
5 years, 2 months ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Use references instead of pointers for CPU context in SimulateCrash The Windows equivalent uses references, which are better than pointers for these const non-null objects. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/599eda0403501596242a99c0aed1df7ed9d68096

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	client/simulate_crash_mac.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	client/simulate_crash_mac.cc	View		3 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 2 months ago (2015-09-25 20:26:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
599eda0403501596242a99c0aed1df7ed9d68096 (presubmit successful).