Issue 1367973004: Make timeline use the same clock source as mojo's tracing infrastructure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367973004: Make timeline use the same clock source as mojo's tracing infrastructure (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make timeline use the same clock source as mojo's tracing infrastructure - This ensures that we have consistent timestamps across processes. - This is necessary to properly support mojo. - Add new public API to query timeline clock. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3d0c4bf586972e4f87e16945503d459befc6d393

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -20 lines)			Patch
M	runtime/include/dart_tools_api.h	View	7 chunks	+13 lines, -11 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.h	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/json_stream.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/os_android.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	runtime/vm/os_win.cc	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	runtime/vm/timeline.cc	View	6 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 2 months ago (2015-09-25 17:04:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d0c4bf586972e4f87e16945503d459befc6d393 (presubmit successful).