Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1367953003:
Allow lack of 'first_gesture_scroll_update_latency' in smoothness tests (Closed)
|
Created:
5 years, 2 months ago by jdduke (slow) Modified:
5 years, 2 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, Yufeng Shen (Slow to review) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow lack of 'first_gesture_scroll_update_latency' in smoothness tests
Not all smoothness benchmarks perform gesture scrolling, for which cases
no 'first_gesture_scroll_update_latency' values are produced. This lack
of value(s) is treated by the dashboard as a failure, which in turn
prevents aggregate metric computation for the corresponding page set.
BUG=534549
Committed: https://crrev.com/49f9ceeed4bacade3ce7d361642f949deef280e1
Cr-Commit-Position: refs/heads/master@{#351088}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Code review #
Total comments: 1
Patch Set 3 : Rebase #Messages
Total messages: 27 (11 generated)
jdduke@chromium.org changed reviewers: + nednguyen@google.com
nednguyen: PTAL, thanks.
https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:23: value.values is None): I would suggest tracking which pages currently don't perform gesture scrolling & add the condition "value.page.url in _PAGES_BLACK_LIST". This is so we know when some page stop producing first_gesture_scroll_update_latency https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:33: test = smoothness.Smoothness remove test = smoothness.Smoothness here and move it to _Smoothness?
https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:23: value.values is None): On 2015/09/25 20:38:47, nednguyen wrote: > I would suggest tracking which pages currently don't perform gesture scrolling & > add the condition "value.page.url in _PAGES_BLACK_LIST". This is so we know when > some page stop producing first_gesture_scroll_update_latency Done. https://codereview.chromium.org/1367953003/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:33: test = smoothness.Smoothness On 2015/09/25 20:38:47, nednguyen wrote: > remove test = smoothness.Smoothness here and move it to _Smoothness? Done. https://codereview.chromium.org/1367953003/diff/20001/tools/perf/benchmarks/s... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1367953003/diff/20001/tools/perf/benchmarks/s... tools/perf/benchmarks/smoothness.py:97: page_set = page_sets.MapsPageSet I'm not sure why maps here doesn't specify the test, seems like a bug but not sure, should be addressed separately.
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367953003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)
The CQ bit was checked by jdduke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367953003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)
The CQ bit was checked by jdduke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/1367953003/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367953003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_b...)
The CQ bit was checked by jdduke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367953003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/...)
On 2015/09/28 16:03:49, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_perf_bisect on tryserver.chromium.perf (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/...) If you tested this out on your local machine, feel free to remove the CQ_EXTRA_TRYBOTS due to unrelated compile error.
The CQ bit was checked by jdduke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367953003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367953003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/49f9ceeed4bacade3ce7d361642f949deef280e1 Cr-Commit-Position: refs/heads/master@{#351088} |
