src/api-natives.h - Issue 1367953002: Allow JavaScript accessors on API objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api-natives.h

Issue 1367953002: Allow JavaScript accessors on API objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback. Also add .gyp support for flag. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api-natives.h

diff --git a/src/api-natives.h b/src/api-natives.h

index c5e398296cfb840c52efb0679177ac3995aa8e04..0639677b155fda707b27afff91e2fb9f1a1f41fe 100644

--- a/src/api-natives.h

+++ b/src/api-natives.h

@@ -45,9 +45,8 @@ class ApiNatives {

PropertyAttributes attributes);

static void AddAccessorProperty(Isolate* isolate, Handle<TemplateInfo> info,

- Handle<Name> name,

- Handle<FunctionTemplateInfo> getter,

- Handle<FunctionTemplateInfo> setter,

+ Handle<Name> name, Handle<Object> getter,

+ Handle<Object> setter,

PropertyAttributes attributes);

static void AddNativeDataProperty(Isolate* isolate, Handle<TemplateInfo> info,