Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: src/api-natives.h

Issue 1367953002: Allow JavaScript accessors on API objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: typo, and/or defective time machine. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/api.cc ('K') | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_API_NATIVES_H_ 5 #ifndef V8_API_NATIVES_H_
6 #define V8_API_NATIVES_H_ 6 #define V8_API_NATIVES_H_
7 7
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/property-details.h" 9 #include "src/property-details.h"
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 static void AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info, 43 static void AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
44 Handle<Name> name, Handle<Object> value, 44 Handle<Name> name, Handle<Object> value,
45 PropertyAttributes attributes); 45 PropertyAttributes attributes);
46 46
47 static void AddAccessorProperty(Isolate* isolate, Handle<TemplateInfo> info, 47 static void AddAccessorProperty(Isolate* isolate, Handle<TemplateInfo> info,
48 Handle<Name> name, 48 Handle<Name> name,
49 Handle<FunctionTemplateInfo> getter, 49 Handle<FunctionTemplateInfo> getter,
50 Handle<FunctionTemplateInfo> setter, 50 Handle<FunctionTemplateInfo> setter,
51 PropertyAttributes attributes); 51 PropertyAttributes attributes);
52 52
53 #ifdef V8_JS_ACCESSORS
54 static void AddAccessorProperty(Isolate* isolate, Handle<TemplateInfo> info,
epertoso 2015/09/24 12:09:06 These two overloads of AddAccessorProperty are int
vogelheim 2015/09/24 16:35:49 Done.
55 Handle<Name> name, Handle<JSFunction> getter,
56 Handle<JSFunction> setter,
57 PropertyAttributes attributes);
58 #endif // V8_JS_ACCESSORS
59
53 static void AddNativeDataProperty(Isolate* isolate, Handle<TemplateInfo> info, 60 static void AddNativeDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
54 Handle<AccessorInfo> property); 61 Handle<AccessorInfo> property);
55 }; 62 };
56 63
57 } // namespace internal 64 } // namespace internal
58 } // namespace v8 65 } // namespace v8
59 66
60 #endif 67 #endif
OLDNEW
« src/api.cc ('K') | « src/api.cc ('k') | src/api-natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698