Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1367943002: X87: [runtime] Remove weird pushing of something on StackOverflow. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Remove weird pushing of something on StackOverflow. port 556b522ac62414c87d05f5d6bab33f6b6cab9b13 (r30883) original commit message: We somehow try to push some stuff on the stack when we detect a stack overflow, that we don't need. Even worse we might access outside the valid stack bounds. Since we don't need this, it's gone. BUG= Committed: https://crrev.com/46d61217cb11979436a0037bf679e52965a3d8ca Cr-Commit-Position: refs/heads/master@{#30907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M src/x87/builtins-x87.cc View 5 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-24 10:10:33 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 10:14:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367943002/1
5 years, 3 months ago (2015-09-24 10:15:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 10:37:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 10:38:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d61217cb11979436a0037bf679e52965a3d8ca
Cr-Commit-Position: refs/heads/master@{#30907}

Powered by Google App Engine
This is Rietveld 408576698