CSP source *.x.y should not match host x.y
This fixes a minor CSP bug where a source in a source list with a
wildcard was matching more liberally than it should have. It was
matching a source of the form *.x.y to host x.y when, in fact, it should
only be matching subdomains.
BUG=534542TBR=mkwst@chromium.org
Committed: https://crrev.com/6282934a62f7b1416b677acad89a2880f2de201c
Cr-Commit-Position: refs/heads/master@{#350629}
Adding asvitkine@ as a reviewer for real this time.
5 years, 3 months ago
(2015-09-24 16:29:23 UTC)
#3
Adding asvitkine@ as a reviewer for real this time.
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/histograms.xml#newcode59312 tools/metrics/histograms/histograms.xml:59312: + <int value="930" label="PresentationRequestReconnect"/> Any idea what happened ...
5 years, 3 months ago
(2015-09-24 16:51:01 UTC)
#4
lgtm
https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):
https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:59312: + <int value="930"
label="PresentationRequestReconnect"/>
Any idea what happened to this one? Generally, it's bad practice to change the
meaning of enums, since data from different versions will mean different things,
but will be labeled with the latest histograms.xml change. But perhaps in this
case, the meaning was still the same and the wording was just made more precise?
5 years, 3 months ago
(2015-09-24 17:06:45 UTC)
#5
https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):
https://codereview.chromium.org/1367933003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:59312: + <int value="930"
label="PresentationRequestReconnect"/>
On 2015/09/24 16:51:01, Alexei Svitkine (slow) wrote:
> Any idea what happened to this one? Generally, it's bad practice to change the
> meaning of enums, since data from different versions will mean different
things,
> but will be labeled with the latest histograms.xml change. But perhaps in this
> case, the meaning was still the same and the wording was just made more
precise?
No idea what happened here; this is just the result of running
update_use_counter_feature_enum.py.
jww
The CQ bit was checked by jww@chromium.org
5 years, 3 months ago
(2015-09-24 17:06:50 UTC)
#6
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367933003/1
5 years, 3 months ago
(2015-09-24 17:07:54 UTC)
#7
Issue 1367933003: CSP source *.x.y should not match host x.y
(Closed)
Created 5 years, 3 months ago by jww
Modified 5 years, 3 months ago
Reviewers: Mike West, Alexei Svitkine (slow)
Base URL: https://chromium.googlesource.com/chromium/src@master
Comments: 2