Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: mojo/system/embedder/test_embedder.h

Issue 136793026: Mojo: Add leak detection to mojo::embedder::test::Shutdown(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/system/embedder/test_embedder.h
diff --git a/mojo/system/embedder/test_embedder.h b/mojo/system/embedder/test_embedder.h
index bafae5c63bb734cfe48e9b1a234b9bf17261eafd..2756d8ec28f360316498e8fc9af1a18350876161 100644
--- a/mojo/system/embedder/test_embedder.h
+++ b/mojo/system/embedder/test_embedder.h
@@ -13,8 +13,10 @@ namespace test {
// This shuts down the global, singleton instance. (Note: "Real" embedders are
// not expected to ever shut down this instance. This |Shutdown()| function will
-// do more work to ensure that tests don't leak, etc.)
-MOJO_SYSTEM_IMPL_EXPORT void Shutdown();
+// do more work to ensure that tests don't leak, etc.) Returns true if there
+// were no problems, false if there were leaks -- i.e., handles still open -- or
+// any other problems.
+MOJO_SYSTEM_IMPL_EXPORT bool Shutdown();
} // namespace test
} // namespace embedder

Powered by Google App Engine
This is Rietveld 408576698