Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: PRESUBMIT.py

Issue 136793022: [telemetry] bitmaptools as a standalone executable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix binary mode for stdio on win32 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 883 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" 894 r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]"
895 r"startup_browser_creator\.cc$", 895 r"startup_browser_creator\.cc$",
896 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", 896 r"^chrome[\\\/]installer[\\\/]setup[\\\/].*",
897 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" 897 r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]"
898 r"logging_native_handler\.cc$", 898 r"logging_native_handler\.cc$",
899 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]" 899 r"^content[\\\/]common[\\\/]gpu[\\\/]client[\\\/]"
900 r"gl_helper_benchmark\.cc$", 900 r"gl_helper_benchmark\.cc$",
901 r"^remoting[\\\/]base[\\\/]logging\.h$", 901 r"^remoting[\\\/]base[\\\/]logging\.h$",
902 r"^remoting[\\\/]host[\\\/].*", 902 r"^remoting[\\\/]host[\\\/].*",
903 r"^sandbox[\\\/]linux[\\\/].*", 903 r"^sandbox[\\\/]linux[\\\/].*",
904 r"^tools[\\\/]telemetry[\\\/]telemetry[\\\/]core[\\\/]"
905 r"bitmaptools.cc$",
904 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",)) 906 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",))
905 source_file_filter = lambda x: input_api.FilterSourceFile( 907 source_file_filter = lambda x: input_api.FilterSourceFile(
906 x, white_list=(file_inclusion_pattern,), black_list=black_list) 908 x, white_list=(file_inclusion_pattern,), black_list=black_list)
907 909
908 log_info = [] 910 log_info = []
909 printf = [] 911 printf = []
910 912
911 for f in input_api.AffectedSourceFiles(source_file_filter): 913 for f in input_api.AffectedSourceFiles(source_file_filter):
912 contents = input_api.ReadFile(f, 'rb') 914 contents = input_api.ReadFile(f, 'rb')
913 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): 915 if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents):
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1450 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1452 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1451 1453
1452 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1454 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1453 # unless they're .gyp(i) files as changes to those files can break the gyp 1455 # unless they're .gyp(i) files as changes to those files can break the gyp
1454 # step on that bot. 1456 # step on that bot.
1455 if (not all(re.search('^chrome', f) for f in files) or 1457 if (not all(re.search('^chrome', f) for f in files) or
1456 any(re.search('\.gypi?$', f) for f in files)): 1458 any(re.search('\.gypi?$', f) for f in files)):
1457 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1459 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1458 1460
1459 return trybots 1461 return trybots
OLDNEW
« no previous file with comments | « no previous file | build/all.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698