Issue 136793018: Fix presubmit errors in toolchain2013, so that cq works for depot_tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136793018: Fix presubmit errors in toolchain2013, so that cq works for depot_tools. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews, cmp-cc_chromium.org, ncarter (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

Fix presubmit errors in toolchain2013, so that cq works for depot_tools. No functionality change. TBR=scottmg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245073

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	depot_tools/win_toolchain/toolchain2013.py	View		4 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/136793018/1

6 years, 11 months ago (2014-01-16 02:40:14 UTC) #2

scottmg

6 years, 11 months ago (2014-01-16 03:11:11 UTC) #4

Message was sent while issue was closed.

lgtm

(Sorry, I spent a while trying to get depot_tools presubmit to work on Windows
but haven't got it yet.)