Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 136793014: Remove m_margins member from FrameView (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove m_margins member from FrameView This member is properly updated but it is never used. We can thus remove it entirely, as well as the related code. This actually gets rid of a decent chunk of code in rendering (including virtual function calls). It decreases overall binary size by over 10Kb. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M Source/core/frame/FrameView.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +0 lines, -22 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/rendering/RenderFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFrame.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderPart.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderPart.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-15 19:58:51 UTC) #1
esprehn
lgtm, this is different than the one being used in HTMLBodyElement::insertedInto ?
6 years, 11 months ago (2014-01-15 20:53:10 UTC) #2
Inactive
On 2014/01/15 20:53:10, esprehn wrote: > lgtm, this is different than the one being used ...
6 years, 11 months ago (2014-01-15 20:55:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/136793014/1
6 years, 11 months ago (2014-01-15 20:58:08 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 22:50:25 UTC) #5
Message was sent while issue was closed.
Change committed as 165168

Powered by Google App Engine
This is Rietveld 408576698