Clear DevTools temp storage

Clear DevTools temp storage

Now that DevTools caches CPU and heap profiles in temporary files we need to be careful to remove these files. The files are deleted in case a profile is removed as a result of user action and on DevTools shutdown.

To make sure we don't leave any garbage the temproary storage is also cleared on first attempt to create a new temp file. A SharedWorker is used to synchronize between DevTools front-ends when clearing temp files to avoid removing temp files that might be used by another front-end.

BUG=327298, 324769
R=alph@chromium.org, pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165135

[alph, 2014-01-14 15:46:34]

lgtm

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempStorageSharedWorker.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:70: didClearTempStorage();
Can you call the callback right after you enumerated all the entries, so the
actual removal happens asynchronously?

[yurys, 2014-01-14 15:58:59]

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempStorageSharedWorker.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:70: didClearTempStorage();
On 2014/01/14 15:46:34, alph wrote:
> Can you call the callback right after you enumerated all the entries, so the
> actual removal happens asynchronously?

This would result in a race when one of a clients may start using a directory
which is going to be removed.

[pfeldman, 2014-01-14 16:26:28]

lgtm

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp
File Source/devtools/devtools.gyp (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gyp:441: '<@(devtools_uglify_files)'
codemirror dependency is missing here, JavaScriptFormatter, CSSFormatter are
missing.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gypi
File Source/devtools/devtools.gypi (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gypi:99: 'front_end/HeapSnapshotWorker.js',
Should be in a separate section.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gypi:176: 'front_end/TempStorageSharedWorker.js',
Should not be here.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempFile.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:202: this._fileEntry.remove(didRemove,
didRemove);
function() {}, function() {}

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:329: WebInspector.log("Failed to clear
temp storage: " + event.data,
WebInspector.UIString("Failed: ... %s", event.data)

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempStorageSharedWorker.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:34: self.onconnect =
function (event) {
/**
 * @param {Event} event
 */
self.onconnect = function(event)
{
...

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:54: didClearTempStorage();
"Failed to clear temp storage: " + e.message + " " + e.name ->
WebInspector.log()...

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:56: function didGetFS(fs)
Annotate please

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:60: function
didReadEntries(entries)
ditto

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:75: didDeleteEntry();
ditto

[yurys, 2014-01-15 08:30:10]

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp
File Source/devtools/devtools.gyp (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gyp:441: '<@(devtools_uglify_files)'
On 2014/01/14 16:26:28, pfeldman wrote:
> codemirror dependency is missing here, JavaScriptFormatter, CSSFormatter are
> missing.

Will address this in a separate patch.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gypi
File Source/devtools/devtools.gypi (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gypi:99: 'front_end/HeapSnapshotWorker.js',
On 2014/01/14 16:26:28, pfeldman wrote:
> Should be in a separate section.

Will fix this in a separate patch.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/devtools.gyp...
Source/devtools/devtools.gypi:176: 'front_end/TempStorageSharedWorker.js',
On 2014/01/14 16:26:28, pfeldman wrote:
> Should not be here.

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempFile.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:202: this._fileEntry.remove(didRemove,
didRemove);
On 2014/01/14 16:26:28, pfeldman wrote:
> function() {}, function() {}

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempFile.js:329: WebInspector.log("Failed to clear
temp storage: " + event.data,
On 2014/01/14 16:26:28, pfeldman wrote:
> WebInspector.UIString("Failed: ... %s", event.data)

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/TempStorageSharedWorker.js (right):

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:34: self.onconnect =
function (event) {
On 2014/01/14 16:26:28, pfeldman wrote:
> /**
>  * @param {Event} event
>  */
> self.onconnect = function(event)
> {
> ...

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:54: didClearTempStorage();
On 2014/01/14 16:26:28, pfeldman wrote:
> "Failed to clear temp storage: " + e.message + " " + e.name ->
> WebInspector.log()...

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:56: function didGetFS(fs)
On 2014/01/14 16:26:28, pfeldman wrote:
> Annotate please

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:60: function
didReadEntries(entries)
On 2014/01/14 16:26:28, pfeldman wrote:
> ditto

Done.

https://codereview.chromium.org/136793008/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/TempStorageSharedWorker.js:75: didDeleteEntry();
On 2014/01/14 16:26:28, pfeldman wrote:
> ditto

Done.

[commit-bot: I haz the power, 2014-01-15 08:40:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/136793008/120001

[yurys, 2014-01-15 15:31:19]

Committed patchset #2 manually as r165135 (presubmit successful).