chrome/chrome_repack_locales.gypi - Issue 136793004: Only include ash_strings if use_ash==1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_repack_locales.gypi

Issue 136793004: Only include ash_strings if use_ash==1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed USE_ASH assignment in python Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_repack_locales.gypi

diff --git a/chrome/chrome_repack_locales.gypi b/chrome/chrome_repack_locales.gypi

index 015d541337869d2b2784a4046d4dcd58040df6bf..c80c1252a26b07ee62e63fa04fd8ab72962a727f 100644

--- a/chrome/chrome_repack_locales.gypi

+++ b/chrome/chrome_repack_locales.gypi

@@ -16,7 +16,7 @@

'inputs': [

'tools/build/repack_locales.py',

- '<!@pymod_do_main(repack_locales -i -p <(OS) <(branding_flag) -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(repack_output_dir) <(repack_extra_flags) <(locales))'

+ '<!@pymod_do_main(repack_locales -i -p <(OS) <(branding_flag) -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(repack_output_dir) --use-ash <(use_ash) <(repack_extra_flags) <(locales))'

'outputs': [

'<!@pymod_do_main(repack_locales -o -p <(OS) -g <(grit_out_dir) -s <(SHARED_INTERMEDIATE_DIR) -x <(repack_output_dir) <(locales))'

@@ -28,6 +28,7 @@

'-g', '<(grit_out_dir)',

'-s', '<(SHARED_INTERMEDIATE_DIR)',

'-x', '<(repack_output_dir)/.',

+ '--use-ash', '<(use_ash)',

'<@(repack_extra_flags)',

'<@(locales)',

« no previous file with comments | « no previous file | chrome/chrome_repack_pseudo_locales.gypi » ('j') | chrome/tools/build/repack_locales.py » ('J')