Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367923006: Enhance GN documentation. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enhance GN documentation. This patch updates various GN documentation. BUG= Committed: https://crrev.com/1c3192f7e36fedcaaa02f262df58e246a3114972 Cr-Commit-Position: refs/heads/master@{#350980}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -52 lines) Patch
M tools/gn/docs/reference.md View 1 21 chunks +167 lines, -26 lines 0 comments Download
M tools/gn/variables.cc View 1 18 chunks +130 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
5 years, 2 months ago (2015-09-25 21:16:58 UTC) #2
Bons
lgtm
5 years, 2 months ago (2015-09-25 21:27:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367923006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367923006/20001
5 years, 2 months ago (2015-09-26 04:02:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-26 04:22:01 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-26 04:22:35 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c3192f7e36fedcaaa02f262df58e246a3114972
Cr-Commit-Position: refs/heads/master@{#350980}

Powered by Google App Engine
This is Rietveld 408576698