Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1367923004: blink_perf.dom.textarea-dom: vary text nodes added. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_perf.dom.textarea-dom: vary text nodes added. This benchmark is meant to measure the performance of a sequence of text node appends to a <textarea/> element. Have that sequence consist of varying strings rather than the exact same one. This is done so as to have the measurement not be influenced by whatever reuse of text node strings that the underlying allocator is able to provide if using identical strings. R= BUG= Committed: https://crrev.com/8ac201565c743bdf4723d0a4a4061cc3579f9378 Cr-Commit-Position: refs/heads/master@{#350533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/PerformanceTests/DOM/textarea-dom.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. cf. https://codereview.chromium.org/1355013002/diff/40001/PerformanceTests/DOM/textarea-dom.html#newcode19
5 years, 2 months ago (2015-09-24 10:01:40 UTC) #2
tkent
lgtm
5 years, 2 months ago (2015-09-24 11:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367923004/1
5 years, 2 months ago (2015-09-24 11:22:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-24 11:28:43 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 11:29:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ac201565c743bdf4723d0a4a4061cc3579f9378
Cr-Commit-Position: refs/heads/master@{#350533}

Powered by Google App Engine
This is Rietveld 408576698