Source/WebCore/rendering/RenderTextControlSingleLine.cpp - Issue 13679002: Add StyleChangeState to get rid of a bunch of static state in the render tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/RenderTextControlSingleLine.cpp

Issue 13679002: Add StyleChangeState to get rid of a bunch of static state in the render tree. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/rendering/RenderObject.cpp ('K') | « Source/WebCore/rendering/RenderTextControlSingleLine.h ('k') | Source/WebCore/rendering/RenderTextFragment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/RenderTextControlSingleLine.cpp

diff --git a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp

index 71134f3848e3f541b99223b8750e3e7b4606df40..984913a5118ea0960a7d895592b190ca7948f506 100644

--- a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp

+++ b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp

@@ -235,10 +235,10 @@ bool RenderTextControlSingleLine::nodeAtPoint(const HitTestRequest& request, Hit

return true;

}

-void RenderTextControlSingleLine::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)

+void RenderTextControlSingleLine::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle, const StyleChangeState& state)

{

m_desiredInnerTextLogicalHeight = -1;

- RenderTextControl::styleDidChange(diff, oldStyle);

+ RenderTextControl::styleDidChange(diff, oldStyle, state);

// We may have set the width and the height in the old style in layout().

// Reset them now to avoid getting a spurious layout hint.