Source/WebCore/rendering/RenderFlexibleBox.h - Issue 13679002: Add StyleChangeState to get rid of a bunch of static state in the render tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/rendering/RenderFlexibleBox.h

Issue 13679002: Add StyleChangeState to get rid of a bunch of static state in the render tree. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/rendering/RenderBox.cpp ('K') | « Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp ('k') | Source/WebCore/rendering/RenderFlexibleBox.cpp » ('j') | Source/WebCore/rendering/RenderFlowThread.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/rendering/RenderFlexibleBox.h

diff --git a/Source/WebCore/rendering/RenderFlexibleBox.h b/Source/WebCore/rendering/RenderFlexibleBox.h

index cc14b18687acc74c99345eb7b1964c6abd2a0932..92aae111f2c77948567aceef654e4870e6e0ca74 100644

--- a/Source/WebCore/rendering/RenderFlexibleBox.h

+++ b/Source/WebCore/rendering/RenderFlexibleBox.h

@@ -61,7 +61,7 @@ protected:

virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const OVERRIDE;

virtual void computePreferredLogicalWidths() OVERRIDE;

- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);

+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle, const StyleChangeState&) OVERRIDE;

eseidel 2013/04/05 01:50:36 Makes me wonder a bit why StyleChangeState doesn't

ojan 2013/04/11 02:12:37 I think including StyleDifference makes sense. Inc

esprehn 2013/04/17 03:29:01 I'll fold StyleDifference into the context object.

private:

enum FlexSign {