Issue 1367893003: Removing HttpNetworkLayer::CreateFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367893003: Removing HttpNetworkLayer::CreateFactory (Closed)

Created:
5 years, 3 months ago by Paritosh Kumar

Modified:
5 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removing unused method HttpNetworkLayer::CreateFactory After https://codereview.chromium.org/6402002 no one is using HttpNetworkLayer::CreateFactory. BUG= Committed: https://crrev.com/223d70853072d7cdd94babf87cc2efb53a8895a5 Cr-Commit-Position: refs/heads/master@{#350555}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	net/http/http_network_layer.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
	M	net/http/http_network_layer.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367893003/1

5 years, 3 months ago (2015-09-24 14:19:57 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-24 15:34:55 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/223d70853072d7cdd94babf87cc2efb53a8895a5
Cr-Commit-Position: refs/heads/master@{#350555}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages