Issue 1367863004: Fix ShellHTTPAppTest#QueryHandling test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367863004: Fix ShellHTTPAppTest#QueryHandling test. (Closed)

Created:
5 years, 2 months ago by qsr

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix ShellHTTPAppTest#QueryHandling test. The test was supposing FIFO behavior for messages sent on 2 different message pipes. BUG=Fixes https://github.com/domokit/mojo/issues/444 TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1257b85bd89bdb38db4f3729ffe4cfeeb25150b5

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
	M	shell/shell_apptest.cc	View		1 chunk	+19 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

Committed patchset #1 (id:1) manually as 1257b85bd89bdb38db4f3729ffe4cfeeb25150b5 (presubmit successful).

5 years, 2 months ago (2015-09-24 07:52:16 UTC) #3

jamesr

5 years, 2 months ago (2015-09-24 22:41:07 UTC) #4

Message was sent while issue was closed.

Using lambdas for this seems unnecessarily opaque - at this level it'd be better
to have explicit functions and Bind() the necessary state.  Other than that,
lgtm

Expand Messages | Collapse Messages